chore: run all tests in ci without "local" feature#761
Open
glicht wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
chore: run all tests in ci without "local" feature#761glicht wants to merge 1 commit intomodelcontextprotocol:mainfrom
glicht wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
github-actions
bot
added
T-CI
9 tasks
Member
|
Hi @glicht, could you check the failing test in CI? |
alexhancock
approved these changes
Mar 20, 2026
Contributor
|
yeah, agree with @DaleSeo. if you could please check out then this LGTM |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are many tests that don't run when "local" feature is enabled. These tests were not being run in CI as the tests job runs with all features including "local" and many tests have
not(feature = "local")gate which means they don't run with--all-featuresflag.Added an additional job:
Run Tests (no local feature)which runs all tests without the local feature.There is one tests that is failing:
test_custom_client_request_reaches_server. That needs to be fixed.Local feature was added here during this PR
How Has This Been Tested?
Runs in CI
Breaking Changes
No
Types of changes
Checklist
Additional context